allow cfg attr typeshare -> typeshare2#273
Merged
darrell-roberts merged 14 commits intotypeshare2from Oct 31, 2025
Merged
Conversation
darrell-roberts
force-pushed
the
darrell/allow-cfg-attr-typeshare
branch
from
57eaecf to
e27fbec
Compare
Progdrasil
approved these changes
Oct 24, 2025
darrell-roberts
force-pushed
the
darrell/allow-cfg-attr-typeshare
branch
3 times, most recently
from
610c8a4 to
727040e
Compare
darrell-roberts
force-pushed
the
darrell/allow-cfg-attr-typeshare
branch
from
727040e to
2b5e06a
Compare
darrell-roberts
force-pushed
the
darrell/allow-cfg-attr-typeshare
branch
from
b39c251 to
a59412b
Compare
Progdrasil
approved these changes
Oct 27, 2025
Contributor
Progdrasil
left a comment
Progdrasil
left a comment
There was a problem hiding this comment.
This works perfectly for 1Password/passkey-rs#68
darrell-roberts
force-pushed
the
darrell/allow-cfg-attr-typeshare
branch
3 times, most recently
from
8141de6 to
0b44d4a
Compare
darrell-roberts
force-pushed
the
darrell/allow-cfg-attr-typeshare
branch
from
0b44d4a to
60087a4
Compare
darrell-roberts
changed the title
smcgovern-proj
approved these changes
Oct 31, 2025
Collaborator
smcgovern-proj
left a comment
smcgovern-proj
left a comment
There was a problem hiding this comment.
This LGTM and works locally (with the caveat that I'm not the most familiar with syn as a lib/syn-related idioms.) Thanks a bunch for making the QOL improvements like doc comments + logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using typeshared types may be behind a feature and as such the annotation would be something like
#[cfg_attr(feature = "typeshare-support", typeshare)].This PR adds support for generating typeshare types using a
cfg_attrcondition.I'll be adding this to #274 then porting it back into typeshare2
Other changes: